From 4e50d20d6ddf0ba1bfaaa25684af2ca7336939e2 Mon Sep 17 00:00:00 2001
From: VegOwOtenks <vegowotenks@jossco.de>
Date: Wed, 20 Aug 2025 19:35:54 +0200
Subject: [PATCH] fix[KeyValueMapping]: emit constructor body, commas ... etc

---
 src/Pretty/Serialize.hs | 29 +++++++++++++++++------------
 1 file changed, 17 insertions(+), 12 deletions(-)

diff --git a/src/Pretty/Serialize.hs b/src/Pretty/Serialize.hs
index c406b68..69582e5 100644
--- a/src/Pretty/Serialize.hs
+++ b/src/Pretty/Serialize.hs
@@ -14,7 +14,7 @@
 {-# LANGUAGE StandaloneDeriving #-}
 {-# LANGUAGE DerivingVia #-}
 {-# LANGUAGE TypeFamilies #-}
-module Pretty.Serialize (Serializer, PrettySerialize(..), ShowPrettySerialize(..), run, emit, KeyValueSerialize(..)) where
+module Pretty.Serialize (Serializer, PrettySerialize(..), ShowPrettySerialize(..), run, emit, KeyValueSerialize(..), customField) where
 
 import Data.Text.Lazy.Builder (Builder)
 import Data.Text.Lazy (Text)
@@ -41,6 +41,7 @@ import Data.Set (Set)
 import qualified Data.Set as Set
 import Data.ByteString.Lazy (LazyByteString)
 import Data.ByteString (ByteString)
+import Data.Maybe (fromMaybe)
 
 type Indentation = Word
 
@@ -119,12 +120,13 @@ unnamedField = recordField serializer
 namedField :: Text -> Serializer a -> Serializer a
 namedField name = recordField (const $ emit name)
 
-inConstructor :: Text -> Serializer a -> Serializer a
-inConstructor name body = do
-  oldIndentation <- indentation <$!> getSerializerState
-  emit "::"
-  emit name
+customField :: Serializer () -> Serializer a -> Serializer a
+customField = recordField . const
 
+beginFields :: Maybe (Serializer ()) -> Serializer b -> Serializer b
+beginFields name body = do
+  oldIndentation <- indentation <$!> getSerializerState
+  fromMaybe (pure ()) name
   -- increase the indentation
   modifySerializerState $ \ state -> state { currentFieldIndex = Nothing, indentation = state.increaseIndentation state.indentation  }
 
@@ -142,6 +144,10 @@ inConstructor name body = do
 
   pure result
 
+inNamedConstructor :: Text -> Serializer a -> Serializer a
+inNamedConstructor name = beginFields $ Just (emit "::" >> emit name)
+
+
 inDatatype :: Text -> Serializer b -> Serializer b
 inDatatype name body = do
   emit name
@@ -235,11 +241,10 @@ newtype KeyValueSerialize a = KeyValueSerialize a
 instance (ExtractMappings a, Typeable a, PrettySerialize (KeyType a), PrettySerialize (ValueType a)) => PrettySerialize (KeyValueSerialize a) where
   serializer :: KeyValueSerialize a -> Serializer ()
   serializer (KeyValueSerialize mapping) = do
-    inDatatypeOf mapping $ do
-      forM_ (keyValuePairs mapping) $ \ (key, value) -> do
-        serializer key
-        emit " = "
-        serializer value
+    inDatatypeOf mapping $ do -- set type name
+      beginFields Nothing $ do -- don't set constructor name
+        forM_ (keyValuePairs mapping) $ \ (key, value) -> do -- emit fields
+          customField (serializer key) (serializer value)
 
 deriving via KeyValueSerialize (Data.IArray.Array index element) instance (Data.IArray.Ix index, Typeable index, Typeable element, PrettySerialize index, PrettySerialize element) => PrettySerialize (Data.IArray.Array index element)
 deriving via KeyValueSerialize (List a) instance (Typeable a, PrettySerialize a) => PrettySerialize (List a)
@@ -277,7 +282,7 @@ instance (KnownSymbol name, GenericPrettySerialize a) => GenericPrettySerialize
 -- constructor metadata
 instance (GenericPrettySerialize a, KnownSymbol name) => GenericPrettySerialize (M1 tag (MetaCons name fixity isRecord) a) where
   genericDumpSerializer :: M1 tag (MetaCons name fixity isRecord) a x -> Serializer ()
-  genericDumpSerializer (M1 c) = inConstructor (fromString contructorName) (genericDumpSerializer c)
+  genericDumpSerializer (M1 c) = inNamedConstructor (fromString contructorName) (genericDumpSerializer c)
     where
       contructorName = symbolVal (Proxy @name)