N0ffie/cigui
2
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Update README.md #5

Open
N0ffie wants to merge 2 commits from documentation-changes into main
pull from: documentation-changes
merge into: N0ffie:main
Conversation 5 Commits 2 Files changed 1 +1 -3
N0ffie commented 2025-04-12 21:35:38 +02:00
Owner
Copy link

This stuff wild

This stuff wild
N0ffie added 1 commit 2025-04-12 21:35:39 +02:00 
This stuff wild
N0ffie requested review from Jocelyn 2025-04-12 21:35:42 +02:00
Jocelyn added 1 commit 2025-04-12 21:43:16 +02:00
Jocelyn commented 2025-04-12 21:54:36 +02:00
Owner
Copy link

Wo wir gerade dabei sind würde ich folgende Änderungen vorschlagen:

  • Die Sektion über Templates raus
  • Use exceptions for exceptional cases only => No runtime exceptions
  • Sektion über Best Practises raus (ist größtenteils entweder maximal obvious oder seeeeeehr weird)
  • Die Sektion über General Principles ist auch eher redundant, da das eigentlich bei einem Projekt der Größe erwartet wird denke ich (aber das ist bloß meine Meinung ^^)
Wo wir gerade dabei sind würde ich folgende Änderungen vorschlagen: * Die Sektion über Templates raus * Use exceptions for exceptional cases only => No runtime exceptions * Sektion über Best Practises raus (ist größtenteils entweder maximal obvious oder seeeeeehr weird) * Die Sektion über General Principles ist auch eher redundant, da das eigentlich bei einem Projekt der Größe erwartet wird denke ich (aber das ist bloß meine Meinung ^^)
Jocelyn closed this pull request 2025-04-12 21:54:36 +02:00
Jocelyn reopened this pull request 2025-04-12 21:54:42 +02:00
N0ffie commented 2025-04-13 00:13:40 +02:00
Author
Owner
Copy link

Jo klingt gut, willst du machen?

Jo klingt gut, willst du machen?
👎 1
Jocelyn commented 2025-04-13 22:53:32 +02:00
Owner
Copy link

speaking of README

Include guards with project specific prefix

  • looks inside
  • uses #pragma once

🙃

speaking of README > Include guards with project specific prefix * looks inside * uses `#pragma once` 🙃
N0ffie commented 2025-04-19 20:24:23 +02:00
Author
Owner
Copy link

yea bin eher für #pragma once

yea bin eher für `#pragma once`
👍 1
N0ffie commented 2025-04-19 20:24:58 +02:00
Author
Owner
Copy link

Jo klingt gut, willst du machen?

ich will das aber auch nicht machen

> Jo klingt gut, willst du machen? ich will das aber auch nicht machen
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin documentation-changes:documentation-changes
git checkout documentation-changes

Merge

Merge the changes and update on Forgejo.
git checkout main
git merge --no-ff documentation-changes
git checkout main
git merge --ff-only documentation-changes
git checkout documentation-changes
git rebase main
git checkout main
git merge --no-ff documentation-changes
git checkout main
git merge --squash documentation-changes
git checkout main
git merge --ff-only documentation-changes
git checkout main
git merge documentation-changes
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Jocelyn
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: N0ffie/cigui#5
No description provided.
Delete branch "documentation-changes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?